Fix to ADCS when relayed username is empty #2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name when username is empty
Contributor
|
Hey mate! Sorry for being afk for a while! I'll definitely check that out tomorrow and let you know if it fixes my case! Thanks ! |
Contributor
|
Perfect mate :D! 
|
Collaborator
|
tested ADCS through HTTP with a coerced local account. working ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2054
Exception was triggered because the
usernamewas set as the CommonName of the CSR.When the
usernamewas not given (coerced machine account) that exception was being triggeredUpdated CSR generation to only set CN when it exists
Enhanced certificate name to also consider these scenarios where
usernameis missing